Re: [PATCH 4/4] attr.c: respect core.ignorecase when matching attribute patterns

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2011, 04:01 UTC
Message-ID: <7vsjnyqws3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1316051979-19671-5-git-send-email-drafnel@gmail.com>

Brandon Casey <drafnel@gmail.com> writes:

Show 7 quoted lines

> It's easy to work around this issue.  I could just parse core.ignorecase
> in git_attr_config() and set ignore_case myself like:
>
>    if (!strcmp(var, "core.ignorecase")) {
>            ignore_case = git_config_bool(var, value);
>            return 0;
>    }

I think it is immensely preferrable to do this than cascading to default_config like this patch does and then piling band-aid on top to fix the breakage caused by calling default_config.

An alternative approach may be to move reading of core.attributesfile to default_config, and drop git_config() call from bootstrap_attr_stack(), getting rid of git_attr_config callback altogether.