[PATCH 3/4] builtin/mv.c: plug miniscule memory leak

From: Brandon Casey <drafnel@gmail.com>
Date: Sep 15, 2011, 01:59 UTC
Message-ID: <1316051979-19671-4-git-send-email-drafnel@gmail.com>
In-Reply-To: <1316051979-19671-1-git-send-email-drafnel@gmail.com>

The "it" string would not be free'ed if base_name was non-NULL. Let's free it.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 builtin/mv.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/builtin/mv.c b/builtin/mv.c
index e9d191f..5efe6c5 100644
--- a/builtin/mv.c
+++ b/builtin/mv.c
@@ -29,7 +29,11 @@ static const char **copy_pathspec(const char *prefix, const char **pathspec,
 			to_copy--;
 		if (to_copy != length || base_name) {
 			char *it = xmemdupz(result[i], to_copy);
-			result[i] = base_name ? xstrdup(basename(it)) : it;
+			if (base_name) {
+				result[i] = xstrdup(basename(it));
+				free(it);
+			} else
+				result[i] = it;
 		}
 	}
 	return get_pathspec(prefix, result);

-- 
1.7.6.2