git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] Git commit --patch (again)

From
Jeff King <peff@peff.net>
Date
May 9, 2011, 22:08 UTC
Message-ID
<20110509220806.GC3719@sigill.intra.peff.net>
In-Reply-To
<7vei47q0i6.fsf@alter.siamese.dyndns.org>
On Mon, May 09, 2011 at 09:53:05AM -0700, Junio C Hamano wrote:
> I agree with this. I do not foresee myself using "commit -p" ever for this
> exact reason. I however didn't see anything wrong in the series and I do
> not see any reason to reject it, either. It's just another long rope other
> people can use to tangle their neck with ;-).
Heh. Maybe your title should be "Git Hangman". :)
> > Hmm. Test t7501.8 explicitly tests that this isn't allowed. But the test
> > is poorly written, and falsely returns success even with your patch.
> 
> Thanks. Let me see if I can simply amend what I queued already ;-)

It's unfortunately not quite as simple as having that test succeed, as it changes state that breaks later tests. I didn't investigate deeply, though.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 21 in “Git commit --patch (again)”
  1. 0/3 Git commit --patch (again)conrad.irwin@gmail.com, May 7, 2011
  2. 1/3 Use a temporary index for git commit --interactiveconrad.irwin@gmail.com, May 7, 2011
  3. 2/3 Allow git commit --interactive with pathsconrad.irwin@gmail.com, May 7, 2011
  4. 3/3 Add support for -p/--patch to git-commitconrad.irwin@gmail.com, May 7, 2011
  5. Valentin HaenelMay 7, 2011
  6. Conrad IrwinMay 7, 2011
  7. 3/3 Add support for -p/--patch to git-commitConrad Irwin, May 7, 2011
  8. Junio C HamanoMay 8, 2011
  9. Add commit to list of config.singlekey commandsConrad Irwin, May 7, 2011
  10. Sverre RabbelierMay 7, 2011
  11. Jeff KingMay 9, 2011
  12. Junio C HamanoMay 9, 2011
  13. Jeff KingMay 9, 2011
  14. Junio C HamanoMay 9, 2011
  15. Junio C HamanoMay 9, 2011
  16. Jeff KingMay 10, 2011
  17. Jeff KingMay 10, 2011
  18. Conrad IrwinMay 10, 2011
  19. Test atomic git-commit --interactiveConrad Irwin, May 10, 2011
  20. Jeff KingMay 10, 2011
  21. Conrad IrwinMay 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.