git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] Git commit --patch (again)

From
Jeff King <peff@peff.net>
Date
May 10, 2011, 19:56 UTC
Message-ID
<20110510195646.GC14456@sigill.intra.peff.net>
In-Reply-To
<7vwrhzmnxf.fsf@alter.siamese.dyndns.org>
On Mon, May 09, 2011 at 04:53:00PM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> -- >8 --
> From: Jeff King <peff@peff.net>
> Subject: [PATCH] t7501.8: feed a meaningful command
> 
> The command expects "git commit --interactive <path>" to fail because you
> cannot (yet) limit "commit --interactive" with a pathspec, but even if the
> command allowed to take <path>, the test would have failed as saying just
> 7:quit would leave the index the same as the current commit, leading to an
> attempt to create an empty commit that would fail without --allow-empty.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Thanks. The commit message and SBO-forgery are fine by me. :)
-Peff
Previous: Jeff KingNext: Conrad Irwin
Message 17 of 21 in “Git commit --patch (again)”
  1. 0/3 Git commit --patch (again)conrad.irwin@gmail.com, May 7, 2011
  2. 1/3 Use a temporary index for git commit --interactiveconrad.irwin@gmail.com, May 7, 2011
  3. 2/3 Allow git commit --interactive with pathsconrad.irwin@gmail.com, May 7, 2011
  4. 3/3 Add support for -p/--patch to git-commitconrad.irwin@gmail.com, May 7, 2011
  5. Valentin HaenelMay 7, 2011
  6. Conrad IrwinMay 7, 2011
  7. 3/3 Add support for -p/--patch to git-commitConrad Irwin, May 7, 2011
  8. Junio C HamanoMay 8, 2011
  9. Add commit to list of config.singlekey commandsConrad Irwin, May 7, 2011
  10. Sverre RabbelierMay 7, 2011
  11. Jeff KingMay 9, 2011
  12. Junio C HamanoMay 9, 2011
  13. Jeff KingMay 9, 2011
  14. Junio C HamanoMay 9, 2011
  15. Junio C HamanoMay 9, 2011
  16. Jeff KingMay 10, 2011
  17. Jeff KingMay 10, 2011
  18. Conrad IrwinMay 10, 2011
  19. Test atomic git-commit --interactiveConrad Irwin, May 10, 2011
  20. Jeff KingMay 10, 2011
  21. Conrad IrwinMay 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.