git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Test atomic git-commit --interactive

From
Conrad Irwin <conrad.irwin@gmail.com>
Date
May 10, 2011, 19:12 UTC
Message-ID
<1305054751-12327-1-git-send-email-conrad.irwin@gmail.com>
In-Reply-To
<BANLkTikwjZkzMxksBsVTFRYdhE3L6ZQM0A@mail.gmail.com>
Signed-off-by: Conrad Irwin <conrad.irwin@gmail.com>
---
 t/t7501-commit.sh |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
index a76c474..2a4e453 100755
--- a/t/t7501-commit.sh
+++ b/t/t7501-commit.sh
@@ -130,6 +130,15 @@ test_expect_success PERL \
 	"interactive add" \
 	"echo 7 | git commit --interactive | grep 'What now'"
 
+test_expect_success PERL \
+	"--interactive doesn't change index if editor aborts" \
+	"EDITOR=false echo zoo >file && \
+	test_must_fail git diff --exit-code > diff1 && \
+	(echo u ; echo '*' ; echo q) |\
+	test_must_fail git commit --interactive && \
+	git diff > diff2 && \
+	git diff --no-index diff1 diff2"
+
 test_expect_success \
 	"showing committed revisions" \
 	"git rev-list HEAD >current"
-- 
1.7.5.188.g4817
Previous: Conrad IrwinNext: Jeff King
Message 19 of 21 in “Git commit --patch (again)”
  1. 0/3 Git commit --patch (again)conrad.irwin@gmail.com, May 7, 2011
  2. 1/3 Use a temporary index for git commit --interactiveconrad.irwin@gmail.com, May 7, 2011
  3. 2/3 Allow git commit --interactive with pathsconrad.irwin@gmail.com, May 7, 2011
  4. 3/3 Add support for -p/--patch to git-commitconrad.irwin@gmail.com, May 7, 2011
  5. Valentin HaenelMay 7, 2011
  6. Conrad IrwinMay 7, 2011
  7. 3/3 Add support for -p/--patch to git-commitConrad Irwin, May 7, 2011
  8. Junio C HamanoMay 8, 2011
  9. Add commit to list of config.singlekey commandsConrad Irwin, May 7, 2011
  10. Sverre RabbelierMay 7, 2011
  11. Jeff KingMay 9, 2011
  12. Junio C HamanoMay 9, 2011
  13. Jeff KingMay 9, 2011
  14. Junio C HamanoMay 9, 2011
  15. Junio C HamanoMay 9, 2011
  16. Jeff KingMay 10, 2011
  17. Jeff KingMay 10, 2011
  18. Conrad IrwinMay 10, 2011
  19. Test atomic git-commit --interactiveConrad Irwin, May 10, 2011
  20. Jeff KingMay 10, 2011
  21. Conrad IrwinMay 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.