From: Jeff King <peff@peff.net>
Date: Mon, 09 May 2011 22:08:06 GMT
Subject: Re: [PATCH v3 0/3] Git commit --patch (again)
Message-ID: <20110509220806.GC3719@sigill.intra.peff.net>
In-Reply-To: <7vei47q0i6.fsf@alter.siamese.dyndns.org>

On Mon, May 09, 2011 at 09:53:05AM -0700, Junio C Hamano wrote:

> I agree with this. I do not foresee myself using "commit -p" ever for this
> exact reason. I however didn't see anything wrong in the series and I do
> not see any reason to reject it, either. It's just another long rope other
> people can use to tangle their neck with ;-).

Heh. Maybe your title should be "Git Hangman". :)

> > Hmm. Test t7501.8 explicitly tests that this isn't allowed. But the test
> > is poorly written, and falsely returns success even with your patch.
> 
> Thanks. Let me see if I can simply amend what I queued already ;-)

It's unfortunately not quite as simple as having that test succeed, as
it changes state that breaks later tests. I didn't investigate deeply,
though.

-Peff