Re: [PATCH 3/7] gitweb: separate heads and remotes lists
On Thu, 16 Sep 2010, Ævar Arnfjörð Bjarmason wrote:
Show 14 quoted lines
> On Thu, Sep 16, 2010 at 09:31, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
>
> > + if (@remotelist) {
> > + git_print_header_div('remotes');
> > + git_heads_body(\@remotelist, $head, 0, 15,
> > + $#remotelist <= 15 ? undef :
> > + $cgi->a({-href => href(action=>"remotes")}, "..."));
> > + }
>
> Nit: The $# syntax is pseudo-deprecated, and since you use 16 as a
> constant above this would be clearer anyway:
>
> @remotelist <= 16 ? undef : ...Actually gitweb uses *15* as a constant above...
--
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>