Re: [PATCH 1/7] gitweb: introduce remote_heads feature
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Sep 17, 2010, 15:39 UTC
- Message-ID
- <AANLkTin43YXnfETqK2ZJASaT5gMemrJqiX+xzfn13s7n@mail.gmail.com>
- In-Reply-To
- <201009162341.20380.jnareb@gmail.com>
2010/9/16 Jakub Narebski <jnareb@gmail.com>:
Show 16 quoted lines
> On Thu, 16 Sep 2010, Giuseppe Bilotta wrote:
>> or return;
>> while (my $line = <$fd>) {
>> my %ref_item;
>> @@ -3160,8 +3174,9 @@ sub git_get_heads_list {
>> my ($committer, $epoch, $tz) =
>> ($committerinfo =~ /^(.*) ([0-9]+) (.*)$/);
>> $ref_item{'fullname'} = $name;
>> - $name =~ s!^refs/heads/!!;
>> + $name =~ s!^refs/(head|remote)s/!!;
>>
>> + $ref_item{'class'} = $1;
>
> Is it used anywhere, or is it left to be used by a further commit in
> the series? If it is the latter, perhaps it would be worth mentioning
> in the commit message?Actually, I think this might be a leftover from some previous iteration (IIRC my first version of this patchset listed all heads under 'heads' grouping them by the class defined here, whereas now we have the two separate sections). I should probably scratch it (even though a similar mechanism is already in place in format_ref_marker and it might be useful to coalesce this when parsing refs)
-- Giuseppe "Oblomov" Bilotta