Re: [PATCH 6/7] gitweb: group styling
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Sep 17, 2010, 16:49 UTC
- Message-ID
- <AANLkTi=8x4JuK99W5BOfUBVUza1sUXE3e_mDOq9-wF_z@mail.gmail.com>
- In-Reply-To
- <201009171826.15454.jnareb@gmail.com>
2010/9/17 Jakub Narebski <jnareb@gmail.com>:
Show 14 quoted lines
> On Thu, 16 Sep 2010, Giuseppe Bilotta wrote:
>
>> +div.group {
>> + margin: .5em;
>> + border: 1px solid #d9d8d1;
>> + display: inline-block;
>
> Is this 'display: inline-block;' really necessary? I think we can do
> without it (and I've heard that there are problems with it, but those
> might not matter in layout used by gitweb).
>
> Otherwise nice.
>
>> +}I'm not aware of problems with inline-block (I can check quirksmode.org though if necessary), but without it the divs will be as large as the _containing_ block, meaning that each div will be ultimately as large as the page. By using inline-block, instead, they become as large as the _contained_ stuff, thus fitting the inner table.
-- Giuseppe "Oblomov" Bilotta