From: Jakub Narebski <jnareb@gmail.com>
Date: Thu, 16 Sep 2010 22:30:05 GMT
Subject: Re: [PATCH 3/7] gitweb: separate heads and remotes lists
Message-ID: <201009170030.05999.jnareb@gmail.com>
In-Reply-To: <AANLkTi=N=jyj8ueVNu601N9qtBktmC-kVv9+0jSA=Sv-@mail.gmail.com>

On Thu, 16 Sep 2010, Ævar Arnfjörð Bjarmason wrote:
> On Thu, Sep 16, 2010 at 09:31, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
> 
> > +       if (@remotelist) {
> > +               git_print_header_div('remotes');
> > +               git_heads_body(\@remotelist, $head, 0, 15,
> > +                              $#remotelist <= 15 ? undef :
> > +                              $cgi->a({-href => href(action=>"remotes")}, "..."));
> > +       }
> 
> Nit: The $# syntax is pseudo-deprecated, and since you use 16 as a
> constant above this would be clearer anyway:
> 
>     @remotelist <= 16 ? undef : ...

Actually gitweb uses *15* as a constant above... 

-- 
Jakub Narebski
Poland