git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes

From
Shawn O. Pearce <spearce@spearce.org>
Date
Feb 4, 2010, 17:59 UTC
Message-ID
<20100204175918.GB18548@spearce.org>
In-Reply-To
<alpine.LFD.2.00.1002041249200.1681@xanadu.home>
Nicolas Pitre <nico@fluxnic.net> wrote:
Show 20 quoted lines
> On Thu, 4 Feb 2010, Shawn O. Pearce wrote:
> 
> > How about for a transition period we do:
> > 
> >   if (v < 8192) {
> >   	warning("max-pack-size is now in bytes, assuming %dm", v);
> > 	v *= 1024 * 1024;
> >   }
> > 
> > So that existing users won't be completely broken if they are
> > relying on this flag, and have some time to adjust.
> 
> For 'git fast-import' which is not meant to be directly user operated 
> this makes sense.  I don't think this is a good idea for 'git repack' 
> though.  In the later case it is best if the user simply adjust right 
> away.
> 
> Also the warning text above could be less ambigous. Something like:
> 
> 	"max-pack-size is now in bytes, assuming --max-pack-size=%dm"

ACK on the fixed warning text. I lacked enough coffee at the time to write intelligent text.

-- 
Shawn.
Previous: Nicolas PitreNext: Junio C Hamano
Message 9 of 16 in “fix multiple issues with t5300”
  1. 1/3 fix multiple issues with t5300Nicolas Pitre, Feb 4, 2010
  2. 2/3 pack-objects: fix pack generation when using pack_size_limitNicolas Pitre, Feb 4, 2010
  3. 3/3 make --max-pack-size argument to 'git pack-object' count in bytesNicolas Pitre, Feb 4, 2010
  4. Shawn O. PearceFeb 4, 2010
  5. Junio C HamanoFeb 4, 2010
  6. Junio C HamanoFeb 4, 2010
  7. Shawn O. PearceFeb 4, 2010
  8. Nicolas PitreFeb 4, 2010
  9. Shawn O. PearceFeb 4, 2010
  10. fast-import: count --max-pack-size in bytesJunio C Hamano, Feb 4, 2010
  11. Shawn O. PearceFeb 4, 2010
  12. Ilari LiusvaaraFeb 4, 2010
  13. Nicolas PitreFeb 4, 2010
  14. Shawn O. PearceFeb 4, 2010
  15. Nicolas PitreFeb 4, 2010
  16. Shawn O. PearceFeb 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.