From: Shawn O. Pearce <spearce@spearce.org>
Date: Thu, 04 Feb 2010 17:59:18 GMT
Subject: Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes
Message-ID: <20100204175918.GB18548@spearce.org>
In-Reply-To: <alpine.LFD.2.00.1002041249200.1681@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> wrote:
> On Thu, 4 Feb 2010, Shawn O. Pearce wrote:
> 
> > How about for a transition period we do:
> > 
> >   if (v < 8192) {
> >   	warning("max-pack-size is now in bytes, assuming %dm", v);
> > 	v *= 1024 * 1024;
> >   }
> > 
> > So that existing users won't be completely broken if they are
> > relying on this flag, and have some time to adjust.
> 
> For 'git fast-import' which is not meant to be directly user operated 
> this makes sense.  I don't think this is a good idea for 'git repack' 
> though.  In the later case it is best if the user simply adjust right 
> away.
> 
> Also the warning text above could be less ambigous. Something like:
> 
> 	"max-pack-size is now in bytes, assuming --max-pack-size=%dm"

ACK on the fixed warning text.  I lacked enough coffee at the time
to write intelligent text.

-- 
Shawn.