git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes

From
Nicolas Pitre <nico@fluxnic.net>
Date
Feb 4, 2010, 18:11 UTC
Message-ID
<alpine.LFD.2.00.1002041309090.1681@xanadu.home>
In-Reply-To
<20100204180015.GC18548@spearce.org>
On Thu, 4 Feb 2010, Shawn O. Pearce wrote:
Show 20 quoted lines
> Nicolas Pitre <nico@fluxnic.net> wrote:
> > >  --max-pack-size=<n>::
> > > -	Maximum size of each output packfile, expressed in MiB.
> > > -	The default is 4096 (4 GiB) as that is the maximum allowed
> > > +	Maximum size of each output packfile.
> > > +	The default is 4 GiB as that is the maximum allowed
> > >  	packfile size (due to file format limitations). Some
> > >  	importers may wish to lower this, such as to ensure the
> > >  	resulting packfiles fit on CDs.
> > 
> > What file format limitation is alluded to here?  It has been a while 
> > since the 4GB limit on pack file format has been removed.
> 
> The pack index v1 32 bit offset thing.  Which you fixed.
> 
> > If this is a 
> > limitation of fast-import only then maybe this should be explained more 
> > explicitly.
> 
> Damn.  It is.  fast-import can't write a v2 index.  Ugh.

Isn't it using write_idx_file()? That function would do it all for you already.

Nicolas
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 15 of 16 in “fix multiple issues with t5300”
  1. 1/3 fix multiple issues with t5300Nicolas Pitre, Feb 4, 2010
  2. 2/3 pack-objects: fix pack generation when using pack_size_limitNicolas Pitre, Feb 4, 2010
  3. 3/3 make --max-pack-size argument to 'git pack-object' count in bytesNicolas Pitre, Feb 4, 2010
  4. Shawn O. PearceFeb 4, 2010
  5. Junio C HamanoFeb 4, 2010
  6. Junio C HamanoFeb 4, 2010
  7. Shawn O. PearceFeb 4, 2010
  8. Nicolas PitreFeb 4, 2010
  9. Shawn O. PearceFeb 4, 2010
  10. fast-import: count --max-pack-size in bytesJunio C Hamano, Feb 4, 2010
  11. Shawn O. PearceFeb 4, 2010
  12. Ilari LiusvaaraFeb 4, 2010
  13. Nicolas PitreFeb 4, 2010
  14. Shawn O. PearceFeb 4, 2010
  15. Nicolas PitreFeb 4, 2010
  16. Shawn O. PearceFeb 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.