Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes
- From
Nicolas Pitre <nico@fluxnic.net>
- Date
- Feb 4, 2010, 18:11 UTC
- Message-ID
- <alpine.LFD.2.00.1002041309090.1681@xanadu.home>
- In-Reply-To
- <20100204180015.GC18548@spearce.org>
On Thu, 4 Feb 2010, Shawn O. Pearce wrote:
Show 20 quoted lines
> Nicolas Pitre <nico@fluxnic.net> wrote: > > > --max-pack-size=<n>:: > > > - Maximum size of each output packfile, expressed in MiB. > > > - The default is 4096 (4 GiB) as that is the maximum allowed > > > + Maximum size of each output packfile. > > > + The default is 4 GiB as that is the maximum allowed > > > packfile size (due to file format limitations). Some > > > importers may wish to lower this, such as to ensure the > > > resulting packfiles fit on CDs. > > > > What file format limitation is alluded to here? It has been a while > > since the 4GB limit on pack file format has been removed. > > The pack index v1 32 bit offset thing. Which you fixed. > > > If this is a > > limitation of fast-import only then maybe this should be explained more > > explicitly. > > Damn. It is. fast-import can't write a v2 index. Ugh.
Isn't it using write_idx_file()? That function would do it all for you already.
Nicolas