Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 4, 2010, 04:38 UTC
- Message-ID
- <7v7hqtty38.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20100204040046.GR14799@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 16 quoted lines
> Nicolas Pitre <nico@fluxnic.net> wrote: >> The value passed to --max-pack-size used to count in MiB which was >> inconsistent with the corresponding configuration variable as well as >> other command arguments which are defined to count in bytes with an >> optional unit suffix. This brings --max-pack-size in line with the >> rest of Git. > ... >> Documentation/RelNotes-1.7.0.txt | 8 +++++++- >> Documentation/config.txt | 11 +++++++---- >> Documentation/git-pack-objects.txt | 5 +++-- >> Documentation/git-repack.txt | 8 +++++--- >> builtin-pack-objects.c | 11 ++++++----- >> t/t5300-pack-object.sh | 14 ++++++++------ >> 6 files changed, 36 insertions(+), 21 deletions(-) > > Shouldn't we also change fast-import.c ?
Surely; could you do the honors? I cannot really decide how big the deal would be to break backward compatibility for max-pack-size myself.