Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes

From: Nicolas Pitre <nico@fluxnic.net>
Date: Feb 4, 2010, 17:49 UTC
Message-ID: <alpine.LFD.2.00.1002041243570.1681@xanadu.home>
In-Reply-To: <7vtytxexjl.fsf@alter.siamese.dyndns.org>

On Thu, 4 Feb 2010, Junio C Hamano wrote:

Show 12 quoted lines

> -- >8 --
> Subject: [PATCH] fast-import: count --max-pack-size in bytes
> 
> Similar in spirit to 07cf0f2 (make --max-pack-size argument to 'git
> pack-object' count in bytes, 2010-02-03) which made the option by the same
> name to pack-objects, this counts the pack size limit in bytes.
> 
> In order not to cause havoc with people used to the previous megabyte
> scale, and because this is a sane thing to do anyway, a minimum size of 1
> MiB is enforced to avoid an explosion of pack files.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

ACK.

Show 8 quoted lines

>  --max-pack-size=<n>::
> -	Maximum size of each output packfile, expressed in MiB.
> -	The default is 4096 (4 GiB) as that is the maximum allowed
> +	Maximum size of each output packfile.
> +	The default is 4 GiB as that is the maximum allowed
>  	packfile size (due to file format limitations). Some
>  	importers may wish to lower this, such as to ensure the
>  	resulting packfiles fit on CDs.

What file format limitation is alluded to here? It has been a while since the 4GB limit on pack file format has been removed. If this is a limitation of fast-import only then maybe this should be explained more explicitly.

Nicolas