From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Fri, 29 Jan 2010 15:20:35 GMT
Subject: Re: [PATCHv4 2/2] filter-branch: Add tests for submodules in tree-filter
Message-ID: <201001291620.35269.sojkam1@fel.cvut.cz>
In-Reply-To: <7vaavxlwoz.fsf@alter.siamese.dyndns.org>

On Thursday 28 of January 2010 22:57:16 Junio C Hamano wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
> > +test_expect_success 'setup submodule' '
> > +	rm -rf * .*
> 
> Yikes.  Please don't do this.
> 
> [...]
> 
> but it would be preferable to be even more explicit "rm -fr ?* .git".

Fixed. I did it like you suggested.

> Also make sure you don't break the chain of "&&" unnecessarily.
> 

Fixed.

I've also split each my test into two separate tests. In the first one I 
perform the rewrite and in the second I test that the result is what was 
expected. I did it because the other tests in this file are structured the 
same way.

Cheers,
Michal