git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] completion: Use consistent if [...] convention. No test.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Feb 11, 2009, 18:35 UTC
Message-ID
<20090211183557.GP30949@spearce.org>
In-Reply-To
<7v1vu4g78q.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> >> -			elif test -f "$g/rebase-apply/applying"
> >> -			then
> >> +            elif [ -f "$g/rebase-apply/applying" ]; then
> >
> > There is some sort of whitespace damage right here, the elif doesn't
> > seem to line up correctly.
> 
> If that is the only gripe and otherwise if you are Ok with the patch, I'll
> queue the entire series with a fix-up here myself.

Yes, this patch is fine, if you can hand-fix the whitespace damage, please feel free to add my Ack.

-- 
Shawn.
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 21 in “completion: Fixes and better non-work-tree support”
  1. 0/4 completion: Fixes and better non-work-tree supportTed Pavlic, Feb 11, 2009
  2. 1/4 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  3. 2/4 completion: Use consistent if [...] convention. No test.Ted Pavlic, Feb 11, 2009
  4. 3/4 completion: Better __git_ps1 support when not in working directoryTed Pavlic, Feb 11, 2009
  5. 4/4 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  6. Shawn O. PearceFeb 11, 2009
  7. Shawn O. PearceFeb 11, 2009
  8. Shawn O. PearceFeb 11, 2009
  9. Junio C HamanoFeb 11, 2009
  10. Shawn O. PearceFeb 11, 2009
  11. Junio C HamanoFeb 11, 2009
  12. Ted PavlicFeb 11, 2009
  13. Jeff KingFeb 11, 2009
  14. 0/4 completion fixes: Acks, whitespace, and r=""Ted Pavlic, Feb 11, 2009
  15. 1/4 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  16. 2/4 completion: Use consistent if [...] convention. No test.Ted Pavlic, Feb 11, 2009
  17. 3/4 completion: Better __git_ps1 support when not in working directoryTed Pavlic, Feb 11, 2009
  18. 4/4 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  19. Ted PavlicFeb 20, 2009
  20. Thomas RastFeb 20, 2009
  21. Ted PavlicFeb 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.