git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] completion: Use consistent if [...] convention. No test.

From
Ted Pavlic <ted@tedpavlic.com>
Date
Feb 11, 2009, 18:43 UTC
Message-ID
<49931C3F.4000903@tedpavlic.com>
In-Reply-To
<7v63jgg7st.fsf@gitster.siamese.dyndns.org>
> What's with this funny indentation?

In Vim, I have "exapndtabs" set by default. I manually turned it off, but during testing, I must have closed Vim and re-opened and forgot to turn it back off.

Some time ago, I suggested adding a vim modeline to the file to handle turning expandtabs off for everyone who edits it with vim. That change got denied.

If you'd like, I can clean up the whitespace and resubmit with Shawn's Acks.
--Ted
-- 
Ted Pavlic <ted@tedpavlic.com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.
Previous: Junio C HamanoNext: Jeff King
Message 12 of 21 in “completion: Fixes and better non-work-tree support”
  1. 0/4 completion: Fixes and better non-work-tree supportTed Pavlic, Feb 11, 2009
  2. 1/4 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  3. 2/4 completion: Use consistent if [...] convention. No test.Ted Pavlic, Feb 11, 2009
  4. 3/4 completion: Better __git_ps1 support when not in working directoryTed Pavlic, Feb 11, 2009
  5. 4/4 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  6. Shawn O. PearceFeb 11, 2009
  7. Shawn O. PearceFeb 11, 2009
  8. Shawn O. PearceFeb 11, 2009
  9. Junio C HamanoFeb 11, 2009
  10. Shawn O. PearceFeb 11, 2009
  11. Junio C HamanoFeb 11, 2009
  12. Ted PavlicFeb 11, 2009
  13. Jeff KingFeb 11, 2009
  14. 0/4 completion fixes: Acks, whitespace, and r=""Ted Pavlic, Feb 11, 2009
  15. 1/4 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  16. 2/4 completion: Use consistent if [...] convention. No test.Ted Pavlic, Feb 11, 2009
  17. 3/4 completion: Better __git_ps1 support when not in working directoryTed Pavlic, Feb 11, 2009
  18. 4/4 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  19. Ted PavlicFeb 20, 2009
  20. Thomas RastFeb 20, 2009
  21. Ted PavlicFeb 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.