Re: [PATCH 2/4] completion: Use consistent if [...] convention. No test.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 11, 2009, 18:14 UTC
- Message-ID
- <7v63jgg7st.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1234375406-27099-3-git-send-email-ted@tedpavlic.com>
Ted Pavlic <ted@tedpavlic.com> writes:
Show 12 quoted lines
> - if [ -d "$g/rebase-apply" ] > - then > - if test -f "$g/rebase-apply/rebasing" > - then > + if [ -d "$g/rebase-apply" ]; then > + if [ -f "$g/rebase-apply/rebasing" ]; then > r="|REBASE" > - elif test -f "$g/rebase-apply/applying" > - then > + elif [ -f "$g/rebase-apply/applying" ]; then > r="|AM" > else
What's with this funny indentation?
As a general rule, it usually is a good idea to apply clean-up to the codebase before starting substantial work, but that holds true only when the clean-up is undisputed. Otherwise you would end up holding the later, more "interesting" work a hostage to an earlier potentially controversial "clean-up".
I think this particular clean-up makes the odd-ball __git_ps1 more consnstent with the rest of the script, but it ultimately is Shawn's call.