git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] completion fixes: Acks, whitespace, and r=""

From
Ted Pavlic <ted@tedpavlic.com>
Date
Feb 20, 2009, 17:01 UTC
Message-ID
<499EE1DE.2000309@tedpavlic.com>
In-Reply-To
<1234378479-29304-1-git-send-email-ted@tedpavlic.com>

In my latest "git pull," I noticed a few completion changes, but none of these changes were included (and thus on some of my machines, I get unbound variable errors again).

Were these changes finally rejected?

Thanks -- Ted

On 2/11/09 1:54 PM, Ted Pavlic wrote:
Show 10 quoted lines
> * Added Shawn O. Pearce acks
> * Fixed whitespace problem in second patch (vim:expandtabs was on)
> * When in GIT_DIR, set r="" in __git_ps1 as well
>
> Ted Pavlic (4):
>    completion: For consistency, changed "git rev-parse" to __gitdir
>      calls.
>    completion: Use consistent if [...] convention. No test.
>    completion: Better __git_ps1 support when not in working directory
>    completion: More fixes to prevent unbound variable errors.
-- 
Ted Pavlic <ted@tedpavlic.com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.
Previous: Ted PavlicNext: Thomas Rast
Message 19 of 21 in “completion: Fixes and better non-work-tree support”
  1. 0/4 completion: Fixes and better non-work-tree supportTed Pavlic, Feb 11, 2009
  2. 1/4 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  3. 2/4 completion: Use consistent if [...] convention. No test.Ted Pavlic, Feb 11, 2009
  4. 3/4 completion: Better __git_ps1 support when not in working directoryTed Pavlic, Feb 11, 2009
  5. 4/4 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  6. Shawn O. PearceFeb 11, 2009
  7. Shawn O. PearceFeb 11, 2009
  8. Shawn O. PearceFeb 11, 2009
  9. Junio C HamanoFeb 11, 2009
  10. Shawn O. PearceFeb 11, 2009
  11. Junio C HamanoFeb 11, 2009
  12. Ted PavlicFeb 11, 2009
  13. Jeff KingFeb 11, 2009
  14. 0/4 completion fixes: Acks, whitespace, and r=""Ted Pavlic, Feb 11, 2009
  15. 1/4 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  16. 2/4 completion: Use consistent if [...] convention. No test.Ted Pavlic, Feb 11, 2009
  17. 3/4 completion: Better __git_ps1 support when not in working directoryTed Pavlic, Feb 11, 2009
  18. 4/4 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  19. Ted PavlicFeb 20, 2009
  20. Thomas RastFeb 20, 2009
  21. Ted PavlicFeb 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.