From: Shawn O. Pearce <spearce@spearce.org>
Date: Wed, 11 Feb 2009 18:35:57 GMT
Subject: Re: [PATCH 2/4] completion: Use consistent if [...] convention. No test.
Message-ID: <20090211183557.GP30949@spearce.org>
In-Reply-To: <7v1vu4g78q.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> >> -			elif test -f "$g/rebase-apply/applying"
> >> -			then
> >> +            elif [ -f "$g/rebase-apply/applying" ]; then
> >
> > There is some sort of whitespace damage right here, the elif doesn't
> > seem to line up correctly.
> 
> If that is the only gripe and otherwise if you are Ok with the patch, I'll
> queue the entire series with a fix-up here myself.

Yes, this patch is fine, if you can hand-fix the whitespace damage,
please feel free to add my Ack.

-- 
Shawn.