Re: epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack))

From: Boyd Stephen Smith Jr. <bss03@volumehost.net>
Date: Dec 11, 2008, 01:03 UTC
Message-ID: <200812101903.58980.bss03@volumehost.net>
In-Reply-To: <alpine.LFD.2.00.0812101523570.3340@localhost.localdomain>

On Wednesday 2008 December 10 17:40:28 Linus Torvalds wrote:

Show 14 quoted lines

>On Wed, 10 Dec 2008, R. Tyler Ballance wrote:
>Anyway, that's a really annoying problem, and it's a bug in git.
>
>That stupid fsck commit walker walks the parents recursively.
>
>And judging by the fact that gdb also SIGSEGV's for you when
>doing the backtrace, it looks like the gdb backtrace tracer is _also_
>recursive, and _also_ hits the same issue ;)
>
>So you have definitely found a real bug.
>
>But we should definitely fix this braindamage in fsck. Rather than
>recursively walk the commits, we should add them to a commit list and just
>walk the list iteratively.

Suppose I fixed this tonight. Would you need anything other than a patch (series) from me? (E.g. copyright assignment or something else legal [vs. technical])

-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss03@volumehost.net                      ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.org/                      \_/