From: Boyd Stephen Smith Jr. Date: Thu, 11 Dec 2008 01:03:53 GMT Subject: Re: epic fsck SIGSEGV! (was Recovering from epic fail (deleted .git/objects/pack)) Message-ID: <200812101903.58980.bss03@volumehost.net> In-Reply-To: On Wednesday 2008 December 10 17:40:28 Linus Torvalds wrote: >On Wed, 10 Dec 2008, R. Tyler Ballance wrote: >Anyway, that's a really annoying problem, and it's a bug in git. > >That stupid fsck commit walker walks the parents recursively. > >And judging by the fact that gdb also SIGSEGV's for you when >doing the backtrace, it looks like the gdb backtrace tracer is _also_ >recursive, and _also_ hits the same issue ;) > >So you have definitely found a real bug. > >But we should definitely fix this braindamage in fsck. Rather than >recursively walk the commits, we should add them to a commit list and just >walk the list iteratively. Suppose I fixed this tonight. Would you need anything other than a patch (series) from me? (E.g. copyright assignment or something else legal [vs. technical]) -- Boyd Stephen Smith Jr.                     ,= ,-_-. =. bss03@volumehost.net                      ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' http://iguanasuicide.org/                      \_/