Re: epic fsck SIGSEGV!

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Dec 11, 2008, 17:33 UTC
Message-ID: <alpine.LFD.2.00.0812110928060.3340@localhost.localdomain>
In-Reply-To: <7v63lrupxk.fsf@gitster.siamese.dyndns.org>

On Wed, 10 Dec 2008, Junio C Hamano wrote:

> 
> I'll consider this signed-off and do the usual forging

Yea. I've even tested it a bit now:

	[torvalds@nehalem git]$ ulimit -s 1024
	[torvalds@nehalem git]$ git fsck --full
	Segmentation fault
	[torvalds@nehalem git]$ ./git-fsck --full
	dangling commit 3d00b49495ceff119de52dc5443731e2d8d84b6b
	dangling commit 4e0a3c7de9af3cbb53cc421329f0579679edbb51
	...

so it does seem to fix the issue, and the patch looks safe enough.

It passes all the tests, and works fine on the kernel repo too (ugh, four minutes! I used to run git-fsck religiously every day back in the early days, now I realized that I must not have done so in _months_, and my kernel tree has grown and so has fsck time).

But obviously the true test for fsck is some complex corruption, and I didn't test that. I can't imagine that it introduces any new problems though - but the bugs you can't imagine are always the worst ones ;)

			Linus