[PATCH v3 8/8] enable textconv for diff in verbose status/commit
- From
Jeff King <peff@peff.net>
- Date
- Oct 26, 2008, 04:50 UTC
- Message-ID
- <20081026045002.GH21047@coredump.intra.peff.net>
- In-Reply-To
- <20081026043802.GA14530@coredump.intra.peff.net>
This diff is meant for human consumption, so it makes sense to apply text conversion here, as we would for the regular diff porcelain.
Signed-off-by: Jeff King <peff@peff.net> --- Pretty straightforward, but depends on whether we find 7/8 acceptable.
t/t4030-diff-textconv.sh | 8 ++++++++ wt-status.c | 1 + 2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh index 3945731..09967f5 100755 --- a/t/t4030-diff-textconv.sh +++ b/t/t4030-diff-textconv.sh @@ -76,6 +76,14 @@ test_expect_success 'format-patch produces binary' ' test_cmp expect.binary actual ' +test_expect_success 'status -v produces text' ' + git reset --soft HEAD^ && + git status -v >diff && + find_diff <diff >actual && + test_cmp expect.text actual && + git reset --soft HEAD@{1} +' + cat >expect.stat <<'EOF' file | Bin 2 -> 4 bytes 1 files changed, 0 insertions(+), 0 deletions(-) diff --git a/wt-status.c b/wt-status.c index 54d2f58..6a7645e 100644 --- a/wt-status.c +++ b/wt-status.c @@ -301,6 +301,7 @@ static void wt_status_print_verbose(struct wt_status *s) setup_revisions(0, NULL, &rev, s->reference); rev.diffopt.output_format |= DIFF_FORMAT_PATCH; rev.diffopt.detect_rename = 1; + DIFF_OPT_SET(&rev.diffopt, ALLOW_TEXTCONV); rev.diffopt.file = s->fp; rev.diffopt.close_file = 0; /*
-- 1.6.0.3.524.ge8b2e.dirty