Re: Implementation of a "textconv" filter for easy custom diff.

From: Jeff King <peff@peff.net>
Date: Sep 28, 2008, 16:11 UTC
Message-ID: <20080928161106.GA30199@coredump.intra.peff.net>
In-Reply-To: <vpqd4io1tla.fsf@bauges.imag.fr>

On Sun, Sep 28, 2008 at 11:57:05AM +0200, Matthieu Moy wrote:

> > Neat. I started on something like this quite a while ago,
> 
> Did you publish/send it anywhere?

No, I was waiting to clean it up and test it a bit more.

> Well, OTOH, one could argue that "blame" is based on diff-ing, and
> therefore it's natural to define a diff filter to tell how "blame"
> should work.

Yes, I would have made that argument. ;)

Show 7 quoted lines

> >     [diff "foo"]
> >     xfuncname = "some regex"
> >     binary = auto
> 
> No sure that would actually be useful in real life, but it doesn't
> harm to have it. And the argument "better path forward for defining
> sets of diff tweaks" is a good one IMO.

Yes, I think currently most diff options supersede the decision about whether or not it's binary (like textconv, in which you probably assume the result is diff-able as text). xfuncname doesn't, but the example is perhaps a bit contrived. So I do think of it as more of a way for future expansion.

I seem to recall actually running into this as part of the textconv work I was doing, but now I can't remember the exact details. So that's not that compelling an argumen.t :)

-Peff