Re: [PATCH] Implement a textconv filter for "git diff"
- From
Jeff King <peff@peff.net>
- Date
- Sep 28, 2008, 04:15 UTC
- Message-ID
- <20080928041526.GB24214@coredump.intra.peff.net>
- In-Reply-To
- <1222567618-22156-4-git-send-email-Matthieu.Moy@imag.fr>
On Sun, Sep 28, 2008 at 04:06:56AM +0200, Matthieu Moy wrote:
Show 8 quoted lines
> +static int textconv_two_files(const char *textconv,
> + const char *name_a,
> + const char *name_b,
> + mmfile_t *mf1,
> + mmfile_t *mf2,
> + struct diff_filespec *one,
> + struct diff_filespec *two)
> +{Must we always be textconv'ing two files? What if I am comparing "v1.5:foo.odf" to "foo.txt" in the working tree?
In my implementation, I textconv one at a time. I just did so from fill_mmfile, so all of diff automagically just sees the converted text.
-Peff