Re: [PATCH 4/7] textconv: don't convert for every operation

From: Jeff King <peff@peff.net>
Date: Oct 25, 2008, 19:35 UTC
Message-ID: <20081025193554.GA27457@coredump.intra.peff.net>
In-Reply-To: <7v3aika5l7.fsf@gitster.siamese.dyndns.org>

On Sat, Oct 25, 2008 at 11:32:20AM -0700, Junio C Hamano wrote:

> The end result may not be that much different, but I find the latter
> easier to follow for three reasons:

Your reasoning here is sound. My initial thought was to make it a one-liner change to "turn on" text conversion in other spots. But

  a) it didn't turn out that way, since you still have to keep track of
     the "did I textconv" when determining binary-ness, and whether to
     free()

  b) we don't actually want to do it anywhere else (except perhaps, as I
     mentioned, in blame, but that is a totally different interface
     anyway)

I will re-roll my latest series according to your recommendation (unless you are set on reverting the first part; if so, please tell me asap so I can work under that assumption).

-Peff