git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.

From
Jeff King <peff@peff.net>
Date
Oct 22, 2008, 20:40 UTC
Message-ID
<20081022204030.GB4585@coredump.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.0810222220410.22125@pacific.mpi-cbg.de.mpi-cbg.de>
On Wed, Oct 22, 2008 at 10:29:39PM +0200, Johannes Schindelin wrote:
Show 5 quoted lines
> > Not all greps support "-e", but in this case we can easily
> > convert it to a single extended regex.
> 
> I really wonder if we cannot catch these things (unportable grep, sed, etc 
> invokations) with a simple patch to the pre-commit hook.

We could probably write a hook for some of the simpler ones, but we would have quite a few false negatives, I suspect.

FWIW, I am not finding these portability problems by hand. I am nightly auto-building and testing Junio's maint, master, and next on Solaris 8 and FreeBSD, and Mike Ralphson is doing the same for AIX. So while we could perhaps catch them sooner, I am very happy to have caught several issues recently in next, _before_ they hit master.

-Peff
Previous: Johannes SchindelinNext: Jakub Narebski
Message 11 of 13 in “builtin-blame: Reencode commit messages according to git-log rules.”
  1. builtin-blame: Reencode commit messages according to git-log rules.Alexander Gavrilov, Oct 21, 2008
  2. Jeff KingOct 22, 2008
  3. Alexander GavrilovOct 22, 2008
  4. Jeff KingOct 22, 2008
  5. Alexander GavrilovOct 22, 2008
  6. Jeff KingOct 22, 2008
  7. Junio C HamanoOct 22, 2008
  8. Jeff KingOct 22, 2008
  9. Jeff KingOct 22, 2008
  10. Johannes SchindelinOct 22, 2008
  11. Jeff KingOct 22, 2008
  12. Jakub NarebskiOct 22, 2008
  13. Jeff KingOct 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.