Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.

From: Jeff King <peff@peff.net>
Date: Oct 22, 2008, 19:14 UTC
Message-ID: <20081022191415.GA31568@coredump.intra.peff.net>
In-Reply-To: <7vd4hsv46z.fsf@gitster.siamese.dyndns.org>

On Wed, Oct 22, 2008 at 12:07:48PM -0700, Junio C Hamano wrote:

> Yuck.  Solaris 8 /usr/bin/grep does not even grok "-e", so we cannot do a
> more obvious:
> 
> 	grep -e "^author " -e "^summary "

Yep. I already introduced one use of egrep for a similar case in 8753941 (tests: grep portability fixes).

> Do people build with NO_EXTERNAL_GREP on older Solaris?

Yep. See:

  http://repo.or.cz/w/git/gitbuild.git?a=blob;f=jk/solaris/config.mak;hb=platform

for the gory details (boy, I wish we had nice PATH_INFO-based gitweb URLs...).

> git-submodule.sh uses grep "-e" to look for two patterns and I suspect
> older Solaris would have the same issue.

Yes, that code will break on Solaris. Most of my portability fixes have been in direct response to tests, so I guess we are not testing git-submodule very well.

-Peff