Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2008, 19:07 UTC
Message-ID: <7vd4hsv46z.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081022082016.GA18473@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Wed, Oct 22, 2008 at 12:55:57AM +0400, Alexander Gavrilov wrote:
>
>> +test_expect_success \
>> +	'blame respects i18n.commitencoding' '
>> +	git blame --incremental file | \
>> +		grep "^\(author\|summary\) " > actual &&
>> +	test_cmp actual expected
>
> Even though it is POSIX, using backslashed grouping in 'grep' isn't
> portable. It fails at least on Solaris 8, and you have to do:
>
>   egrep "^(author|summary) "
>
> instead. Of course, I can't get your test to pass even with that change,
> but I think that is just a broken iconv on Solaris.

Yuck. Solaris 8 /usr/bin/grep does not even grok "-e", so we cannot do a more obvious:

	grep -e "^author " -e "^summary "

Do people build with NO_EXTERNAL_GREP on older Solaris?

git-submodule.sh uses grep "-e" to look for two patterns and I suspect older Solaris would have the same issue.