Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.

From: Alexander Gavrilov <angavrilov@gmail.com>
Date: Oct 22, 2008, 09:32 UTC
Message-ID: <bb6f213e0810220232p2e7fe3daoa32f46fbe5bef2ac@mail.gmail.com>
In-Reply-To: <20081022085036.GA1454@sigill.intra.peff.net>

On Wed, Oct 22, 2008 at 12:50 PM, Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

> On Wed, Oct 22, 2008 at 12:35:17PM +0400, Alexander Gavrilov wrote:
>
>> > instead. Of course, I can't get your test to pass even with that change,
>> > but I think that is just a broken iconv on Solaris.
>>
>> Hm, which of the conversions fail? You can try manually converting the
>> txt files with the iconv command to figure it out.
>
> Test 2 fails for CP1251 and SJIS.  Manually converting with iconv seems
> to work ok (at least, doing "iconv -f CP1251 -t UTF-8 cp1251.txt"
> produces the same output as "cat utf8.txt".
>
> The output from "t8005-blame-i18n.sh -v -i" is attached (as
> application/octet-stream to protect it from email munging) if that is
> helpful to you. I can't make heads or tails of it.

>From the output it seems that what fails is "-f cp1251 -t sjis" and

"-f utf-8 -t sjis" (remember that blame --incremental produces its output in reverse order compared to the order of commits). Unless blame for some reason actually tries to convert to an entirely different encoding. If tests 4 and 5 pass, you can try adding --encoding=shift-jis to test 2 to check it.

Alexander