From: Jeff King <peff@peff.net>
Date: Wed, 22 Oct 2008 20:40:31 GMT
Subject: Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.
Message-ID: <20081022204030.GB4585@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0810222220410.22125@pacific.mpi-cbg.de.mpi-cbg.de>

On Wed, Oct 22, 2008 at 10:29:39PM +0200, Johannes Schindelin wrote:

> > Not all greps support "-e", but in this case we can easily
> > convert it to a single extended regex.
> 
> I really wonder if we cannot catch these things (unportable grep, sed, etc 
> invokations) with a simple patch to the pre-commit hook.

We could probably write a hook for some of the simpler ones, but we
would have quite a few false negatives, I suspect.

FWIW, I am not finding these portability problems by hand. I am nightly
auto-building and testing Junio's maint, master, and next on Solaris 8
and FreeBSD, and Mike Ralphson is doing the same for AIX. So while we
could perhaps catch them sooner, I am very happy to have caught several
issues recently in next, _before_ they hit master.

-Peff