git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9600: require cvsps 2.1 to perform tests

From
Jeff King <peff@peff.net>
Date
Dec 4, 2007, 15:44 UTC
Message-ID
<20071204154454.GA2994@coredump.intra.peff.net>
In-Reply-To
<7v1wa3aukt.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 03, 2007 at 09:37:54PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> I wonder if it is better to grep for ' [-A] ' instead, like:
> 
> cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p')
> case "$cvsps_supports_A" in
> '')
> 	say 'skipping cvsimport tests, lacking cvsps that supports -A option'
> 	test_done
>         exit
> esac

I am not too opposed to that, but I felt that checking the version was a little bit more future proof. I.e., I have no idea if it is only -A that we need, but I know that 2.1 works and prior to 2.1 doesn't.

-Jeff
Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 18 in “make test failure with latest master”
  1. A Large Angry SCMDec 2, 2007
  2. Jakub NarebskiDec 2, 2007
  3. A Large Angry SCMDec 2, 2007
  4. Jeff KingDec 2, 2007
  5. A Large Angry SCMDec 2, 2007
  6. Johannes SchindelinDec 2, 2007
  7. Jeff KingDec 3, 2007
  8. Johannes SixtDec 3, 2007
  9. Jeff KingDec 3, 2007
  10. A Large Angry SCMDec 3, 2007
  11. Junio C HamanoDec 3, 2007
  12. A Large Angry SCMDec 3, 2007
  13. t9600: require cvsps 2.1 to perform testsJeff King, Dec 4, 2007
  14. Junio C HamanoDec 4, 2007
  15. Jeff KingDec 4, 2007
  16. Junio C HamanoDec 4, 2007
  17. Jeff KingDec 5, 2007
  18. Junio C HamanoDec 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.