Re: [PATCH] t9600: require cvsps 2.1 to perform tests
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 4, 2007, 17:39 UTC
- Message-ID
- <7vhciy5pg0.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071204154454.GA2994@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> On Mon, Dec 03, 2007 at 09:37:54PM -0800, Junio C Hamano wrote: > >> I wonder if it is better to grep for ' [-A] ' instead, like: >> >> cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p') >> case "$cvsps_supports_A" in >> '') >> say 'skipping cvsimport tests, lacking cvsps that supports -A option' >> test_done >> exit >> esac > > I am not too opposed to that, but I felt that checking the version was a > little bit more future proof. I.e., I have no idea if it is only -A that > we need, but I know that 2.1 works and prior to 2.1 doesn't.
You are right about "we may be depending on what 2.1 has other than -A". Will apply as-is.
Thanks, both.
The primary reason I asked about '\[-A\]' was what will happen if somebody uses 2.2.