Re: [PATCH] t9600: require cvsps 2.1 to perform tests

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2007, 05:44 UTC
Message-ID: <7v3auh3dbt.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071205010202.GA4713@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 21 quoted lines

> On Tue, Dec 04, 2007 at 09:39:59AM -0800, Junio C Hamano wrote:
>
>> You are right about "we may be depending on what 2.1 has other than
>> -A".  Will apply as-is.
>> 
>> Thanks, both.
>> 
>> The primary reason I asked about '\[-A\]' was what will happen if
>> somebody uses 2.2.
>
> Yes, it would be nice to be able to easily check >2.1. GNU expr seems to
> handle this ok:
>
>   $ expr 2.2 '>' 2.1
>   1
>   $ expr 2.0 '>' 2.1
>   0
>
> but POSIX seems to mention only integers and string comparison (though
> if all are of the form "x.y", string comparison works). I have no idea
> how portable this is.

Yeah, but it is the same thing -- we know 2.1 works, we do not know if 2.2 will break things for us ;-)

We'll worry about it when somebody with 2.2 complains.