Re: [PATCH] t9600: require cvsps 2.1 to perform tests

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2007, 05:37 UTC
Message-ID: <7v1wa3aukt.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071204014145.GA20145@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 16 quoted lines

> +cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
> +case "$cvsps_version" in
> +2.1)
> +	;;
> +'')
> +	say 'skipping cvsimport tests, cvsps not found'
> +	test_done
> +	exit
> +	;;
> +*)
> +	say 'skipping cvsimport tests, cvsps too old'
> +	test_done
> +	exit
> +	;;
> +esac
> +

I wonder if it is better to grep for ' [-A] ' instead, like:

cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p')
case "$cvsps_supports_A" in
'')
	say 'skipping cvsimport tests, lacking cvsps that supports -A option'
	test_done
        exit
esac