From: Jeff King <peff@peff.net>
Date: Tue, 04 Dec 2007 15:44:54 GMT
Subject: Re: [PATCH] t9600: require cvsps 2.1 to perform tests
Message-ID: <20071204154454.GA2994@coredump.intra.peff.net>
In-Reply-To: <7v1wa3aukt.fsf@gitster.siamese.dyndns.org>

On Mon, Dec 03, 2007 at 09:37:54PM -0800, Junio C Hamano wrote:

> I wonder if it is better to grep for ' [-A] ' instead, like:
> 
> cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p')
> case "$cvsps_supports_A" in
> '')
> 	say 'skipping cvsimport tests, lacking cvsps that supports -A option'
> 	test_done
>         exit
> esac

I am not too opposed to that, but I felt that checking the version was a
little bit more future proof. I.e., I have no idea if it is only -A that
we need, but I know that 2.1 works and prior to 2.1 doesn't.

-Jeff