git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.

From
Jeff King <peff@peff.net>
Date
Oct 10, 2007, 05:10 UTC
Message-ID
<20071010051034.GA30834@coredump.intra.peff.net>
In-Reply-To
<20071009182043.GA2997@steel.home>
On Tue, Oct 09, 2007 at 08:20:43PM +0200, Alex Riesen wrote:
> Your test does not crash on my system and your fix is obviously bogus.
> Just take a look at the only call site of the tail_link_ref: ret
> cannot be NULL. alloc_ref will crash in memset, if this were the case.

His work is almost certainly on top of next, which crashes reliably with the test and has an additional call site for tail_link_ref. Aside from some trailing whitespace in the patch, I think his fix is reasonable.

-Peff
Previous: Alex RiesenNext: Alex Riesen
Message 5 of 10 in “Added a test for fetching remote tags when there is not tags.”
  1. Added a test for fetching remote tags when there is not tags.Väinö Järvelä, Oct 9, 2007
  2. Fixed crash in fetching remote tags when there is not tags.Väinö Järvelä, Oct 9, 2007
  3. Väinö JärveläOct 9, 2007
  4. Alex RiesenOct 9, 2007
  5. Jeff KingOct 10, 2007
  6. Alex RiesenOct 10, 2007
  7. Jeff KingOct 10, 2007
  8. Shawn O. PearceOct 12, 2007
  9. Fix a crash in ls-remote when refspec expands into nothingAlex Riesen, Oct 12, 2007
  10. Lars HjemliOct 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.