git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.

From
VJVäinö Järvelä <v@pp.inet.fi>
Date
Oct 9, 2007, 10:52 UTC
Message-ID
<81553116-3A4F-4526-A772-9A43C53D3E22@pp.inet.fi>
In-Reply-To
<1191919868-4963-2-git-send-email-v@pp.inet.fi>
Hi,

These patches should have been numbered, sorry, The test patch was supposed be number 1 of 2.

The patches were done on top of next. The fix should be checked, as it's mostly a quick fix to get it to work, probably not the correct way to fix that bug, or is it?

-- Väinö

On Oct 9, 2007, at 11:51, Väinö Järvelä wrote:
Show 26 quoted lines
> Signed-off-by: Väinö Järvelä <v@pp.inet.fi>
> ---
>  remote.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/remote.c b/remote.c
> index e7d735b..5e92378 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -537,6 +537,8 @@ static int count_refspec_match(const char  
> *pattern,
>
>  static void tail_link_ref(struct ref *ref, struct ref ***tail)
>  {
> +	if (!ref) return;
> +	
>  	**tail = ref;
>  	while (ref->next)
>  		ref = ref->next;
> -- 
> 1.5.3.4.1156.g5407-dirty
>
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous: Väinö JärveläNext: Alex Riesen
Message 3 of 10 in “Added a test for fetching remote tags when there is not tags.”
  1. Added a test for fetching remote tags when there is not tags.Väinö Järvelä, Oct 9, 2007
  2. Fixed crash in fetching remote tags when there is not tags.Väinö Järvelä, Oct 9, 2007
  3. Väinö JärveläOct 9, 2007
  4. Alex RiesenOct 9, 2007
  5. Jeff KingOct 10, 2007
  6. Alex RiesenOct 10, 2007
  7. Jeff KingOct 10, 2007
  8. Shawn O. PearceOct 12, 2007
  9. Fix a crash in ls-remote when refspec expands into nothingAlex Riesen, Oct 12, 2007
  10. Lars HjemliOct 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.