From: Jeff King <peff@peff.net>
Date: Wed, 10 Oct 2007 05:10:35 GMT
Subject: Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.
Message-ID: <20071010051034.GA30834@coredump.intra.peff.net>
In-Reply-To: <20071009182043.GA2997@steel.home>

On Tue, Oct 09, 2007 at 08:20:43PM +0200, Alex Riesen wrote:

> Your test does not crash on my system and your fix is obviously bogus.
> Just take a look at the only call site of the tail_link_ref: ret
> cannot be NULL. alloc_ref will crash in memset, if this were the case.

His work is almost certainly on top of next, which crashes reliably with
the test and has an additional call site for tail_link_ref. Aside from
some trailing whitespace in the patch, I think his fix is reasonable.

-Peff