git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix a crash in ls-remote when refspec expands into nothing

From
Alex Riesen <raa.lkml@gmail.com>
Date
Oct 12, 2007, 20:40 UTC
Message-ID
<20071012204004.GA6700@steel.home>
In-Reply-To
<20071012040745.GC27899@spearce.org>
Originally-by: Väinö Järvelä <v@pp.inet.fi>
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 remote.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Shawn O. Pearce, Fri, Oct 12, 2007 06:07:45 +0200:
> I think the above patch is the only thing to do here.  Perhaps Alex
> can write up a formal patch and send it to back to the list and CC
> Lars Hjemli <hjemli@gmail.com> so he can put it into the patch queue.
here you go
diff --git a/remote.c b/remote.c
index e7d735b..a25f66d 100644
--- a/remote.c
+++ b/remote.c
@@ -882,7 +882,8 @@ int get_fetch_map(struct ref *remote_refs,
 			    rm->peer_ref->name);
 	}
 
-	tail_link_ref(ref_map, tail);
+	if (ref_map)
+		tail_link_ref(ref_map, tail);
 
 	return 0;
 }
-- 
1.5.3.4.232.ga843
Previous: Shawn O. PearceNext: Lars Hjemli
Message 9 of 10 in “Added a test for fetching remote tags when there is not tags.”
  1. Added a test for fetching remote tags when there is not tags.Väinö Järvelä, Oct 9, 2007
  2. Fixed crash in fetching remote tags when there is not tags.Väinö Järvelä, Oct 9, 2007
  3. Väinö JärveläOct 9, 2007
  4. Alex RiesenOct 9, 2007
  5. Jeff KingOct 10, 2007
  6. Alex RiesenOct 10, 2007
  7. Jeff KingOct 10, 2007
  8. Shawn O. PearceOct 12, 2007
  9. Fix a crash in ls-remote when refspec expands into nothingAlex Riesen, Oct 12, 2007
  10. Lars HjemliOct 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.