Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 9, 2007, 18:20 UTC
Message-ID: <20071009182043.GA2997@steel.home>
In-Reply-To: <81553116-3A4F-4526-A772-9A43C53D3E22@pp.inet.fi>

Väinö Järvelä, Tue, Oct 09, 2007 12:52:01 +0200:

Show 8 quoted lines

> Hi,
> 
> These patches should have been numbered, sorry, The test patch was  
> supposed be number 1 of 2.
> 
> The patches were done on top of next. The fix should be checked, as  
> it's mostly a quick fix to get it to work, probably not the correct  
> way to fix that bug, or is it?

Your test does not crash on my system and your fix is obviously bogus. Just take a look at the only call site of the tail_link_ref: ret cannot be NULL. alloc_ref will crash in memset, if this were the case.

If you can reproduce the crash reliably, try compiling git with -g and run it in your test with valgrind or gdb (assuming these are available to you).