git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't allow newlines to occur in $Id:$ collapse

From
Joshua N Pritikin <jpritikin@pobox.com>
Date
May 25, 2007, 14:40 UTC
Message-ID
<20070525144058.GB5226@always.joy.eth.net>
In-Reply-To
<200705251451.00999.andyparkins@gmail.com>
On Fri, May 25, 2007 at 02:50:53PM +0100, Andy Parkins wrote:
Show 5 quoted lines
> One could even argue that it's not actually an error, if we define keywords to 
> be such that they are not allowed to contain newlines, then the fact that 
> someone has written "$Id:" in their file, with no closing "$" just means that 
> it's not a keyword; and like every other non-keyword bit of data in the file 
> it should be left untouched.
Ah, so the original patch, before I started kibitzing, was correct.
Sorry for the noise.
Previous: Andy ParkinsNext: Junio C Hamano
Message 8 of 13 in “Fix mishandling of $Id$ expanded in the repository copy in convert.c”
  1. Fix mishandling of $Id$ expanded in the repository copy in convert.cAndy Parkins, May 25, 2007
  2. Joshua N PritikinMay 25, 2007
  3. Andy ParkinsMay 25, 2007
  4. Don't allow newlines to occur in $Id:$ collapseAndy Parkins, May 25, 2007
  5. Joshua N PritikinMay 25, 2007
  6. Nicolas PitreMay 25, 2007
  7. Andy ParkinsMay 25, 2007
  8. Joshua N PritikinMay 25, 2007
  9. Junio C HamanoMay 26, 2007
  10. Andy ParkinsMay 26, 2007
  11. Junio C HamanoMay 26, 2007
  12. Andy ParkinsMay 27, 2007
  13. Add test case for $Id$ expanded in the repositoryAndy Parkins, May 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.