Re: [PATCH] Fix mishandling of $Id$ expanded in the repository copy in convert.c

From: Joshua N Pritikin <jpritikin@pobox.com>
Date: May 25, 2007, 10:58 UTC
Message-ID: <20070525105836.GG6667@always.joy.eth.net>
In-Reply-To: <200705251150.09439.andyparkins@gmail.com>

On Fri, May 25, 2007 at 11:50:08AM +0100, Andy Parkins wrote:

Show 13 quoted lines

> +			/*
> +			 * Throw away characters until either
> +			 *  - we reach a "$"
> +			 *  - we run out of bytes (rem == 0)
> +			 */
>  			do {
> -				ch = *cp++;
> +				ch = *cp;
>  				if (ch == '$')
>  					break;
> +				cp++;
>  				rem--;
>  			} while (rem);

Can this loop throw away newlines? Removing newlines seems like a bad idea.