From: Joshua N Pritikin Date: Fri, 25 May 2007 14:40:58 GMT Subject: Re: [PATCH] Don't allow newlines to occur in $Id:$ collapse Message-ID: <20070525144058.GB5226@always.joy.eth.net> In-Reply-To: <200705251451.00999.andyparkins@gmail.com> On Fri, May 25, 2007 at 02:50:53PM +0100, Andy Parkins wrote: > One could even argue that it's not actually an error, if we define keywords to > be such that they are not allowed to contain newlines, then the fact that > someone has written "$Id:" in their file, with no closing "$" just means that > it's not a keyword; and like every other non-keyword bit of data in the file > it should be left untouched. Ah, so the original patch, before I started kibitzing, was correct. Sorry for the noise.