git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't allow newlines to occur in $Id:$ collapse

From
Nicolas Pitre <nico@cam.org>
Date
May 25, 2007, 13:47 UTC
Message-ID
<alpine.LFD.0.99.0705250942500.3366@xanadu.home>
In-Reply-To
<20070525132800.GH6667@always.joy.eth.net>
On Fri, 25 May 2007, Joshua N Pritikin wrote:
Show 14 quoted lines
> On Fri, May 25, 2007 at 02:13:42PM +0100, Andy Parkins wrote:
> > If a newline ever made it into an repository-side expanded $Id$ field,
> > the keyword would still be detected as a keyword and collapsed, before
> > rexpansion, e.g.
> > 
> >  $Id: all of this text would be removed, even if there
> >  were a newline in the middle of it$
> > 
> > This patch catches newlines in this case and abandons treating this as a
> > keyword expansion, this text would be left untouched in the working
> > checkout.
> 
> That's better but I would error out instead of silently ignoring it.
> Your choice.
Erroring out in such a case would simply make the system too obnoxious.

I don't think it is really worth aborting a commit just because you have a bad $Id:$ in one of your file.

Nicolas
Previous: Joshua N PritikinNext: Andy Parkins
Message 6 of 13 in “Fix mishandling of $Id$ expanded in the repository copy in convert.c”
  1. Fix mishandling of $Id$ expanded in the repository copy in convert.cAndy Parkins, May 25, 2007
  2. Joshua N PritikinMay 25, 2007
  3. Andy ParkinsMay 25, 2007
  4. Don't allow newlines to occur in $Id:$ collapseAndy Parkins, May 25, 2007
  5. Joshua N PritikinMay 25, 2007
  6. Nicolas PitreMay 25, 2007
  7. Andy ParkinsMay 25, 2007
  8. Joshua N PritikinMay 25, 2007
  9. Junio C HamanoMay 26, 2007
  10. Andy ParkinsMay 26, 2007
  11. Junio C HamanoMay 26, 2007
  12. Andy ParkinsMay 27, 2007
  13. Add test case for $Id$ expanded in the repositoryAndy Parkins, May 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.