git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix mishandling of $Id$ expanded in the repository copy in convert.c

From
APAndy Parkins <andyparkins@gmail.com>
Date
May 25, 2007, 13:12 UTC
Message-ID
<200705251412.06196.andyparkins@gmail.com>
In-Reply-To
<20070525105836.GG6667@always.joy.eth.net>
On Friday 2007 May 25, Joshua N Pritikin wrote:
> Can this loop throw away newlines? Removing newlines seems like a bad
> idea.

It can and does. My patch is only a bug fix though, not a change in functionality.

It's probably not likely that they will appear inside the $Id: XXXXX $ expansion, and even less likely that that expansion will make it into the repository copy; however it's easily fixed ... patch to follow. 

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
Previous: Joshua N PritikinNext: Andy Parkins
Message 3 of 13 in “Fix mishandling of $Id$ expanded in the repository copy in convert.c”
  1. Fix mishandling of $Id$ expanded in the repository copy in convert.cAndy Parkins, May 25, 2007
  2. Joshua N PritikinMay 25, 2007
  3. Andy ParkinsMay 25, 2007
  4. Don't allow newlines to occur in $Id:$ collapseAndy Parkins, May 25, 2007
  5. Joshua N PritikinMay 25, 2007
  6. Nicolas PitreMay 25, 2007
  7. Andy ParkinsMay 25, 2007
  8. Joshua N PritikinMay 25, 2007
  9. Junio C HamanoMay 26, 2007
  10. Andy ParkinsMay 26, 2007
  11. Junio C HamanoMay 26, 2007
  12. Andy ParkinsMay 27, 2007
  13. Add test case for $Id$ expanded in the repositoryAndy Parkins, May 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.