git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git log [diff-tree options]...

From
THTimo Hirvonen <tihirvon@gmail.com>
Date
Apr 9, 2006, 22:22 UTC
Message-ID
<20060410012258.589f1581.tihirvon@gmail.com>
In-Reply-To
<Pine.LNX.4.63.0604100000430.30000@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> +static int cmd_whatchanged(int argc, const char **argv, char **envp)
> +{
> +	memmove(argv + 2, argv + 1, argc - 1);

Shouldn't the size be sizeof(char *) * argc (NULL terminated array)? There's also overflow...

-- 
http://onion.dynserv.net/~timo/
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 10 of 22 in “git log [diff-tree options]...”
  1. git log [diff-tree options]...Junio C Hamano, Apr 9, 2006
  2. Junio C HamanoApr 9, 2006
  3. Linus TorvaldsApr 9, 2006
  4. Junio C HamanoApr 9, 2006
  5. Linus TorvaldsApr 9, 2006
  6. Junio C HamanoApr 9, 2006
  7. Linus TorvaldsApr 9, 2006
  8. Johannes SchindelinApr 9, 2006
  9. Johannes SchindelinApr 9, 2006
  10. Timo HirvonenApr 9, 2006
  11. Johannes SchindelinApr 10, 2006
  12. Junio C HamanoApr 9, 2006
  13. Linus TorvaldsApr 10, 2006
  14. Johannes SchindelinApr 10, 2006
  15. Randal L. SchwartzApr 11, 2006
  16. Junio C HamanoApr 11, 2006
  17. Petr BaudisApr 11, 2006
  18. Randal L. SchwartzApr 11, 2006
  19. Junio C HamanoApr 10, 2006
  20. tree-diff: do not assume we use only one pathspecJunio C Hamano, Apr 10, 2006
  21. git log --full-diffJunio C Hamano, Apr 10, 2006
  22. Linus TorvaldsApr 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.