From: Timo Hirvonen <tihirvon@gmail.com>
Date: Sun, 09 Apr 2006 22:22:58 GMT
Subject: Re: [PATCH] git log [diff-tree options]...
Message-ID: <20060410012258.589f1581.tihirvon@gmail.com>
In-Reply-To: <Pine.LNX.4.63.0604100000430.30000@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> +static int cmd_whatchanged(int argc, const char **argv, char **envp)
> +{
> +	memmove(argv + 2, argv + 1, argc - 1);

Shouldn't the size be sizeof(char *) * argc (NULL terminated array)?
There's also overflow...

-- 
http://onion.dynserv.net/~timo/